refactor: apply goimports linter
#332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvarga
approved these changes
Dec 6, 2024
| "github.com/google/go-cmp/cmp" | ||
| "github.com/google/go-cmp/cmp/cmpopts" | ||
| "github.com/google/go-containerregistry/pkg/v1" | ||
| v1 "github.com/google/go-containerregistry/pkg/v1" |
There was a problem hiding this comment.
Not quite sure if I understand why it's better formatting to make things ending with "v1" a named import?
There was a problem hiding this comment.
I was curious about that myself but unfortunately I couldn't find a concrete laymen answer, just the issue that lead to it being a thing.
From what I could tell, something has an issue with implicitly-named imports of versions like this maybe because of special handling Go has for major versions of packages, and that resulted in something erroring - I think it might be a technical edge case in goimports rather than an actual language constraint, and that they decided it was fine to just make the convention to explicitly define the package name in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the
goimportslinter to ensure our imports are consistently and well formatted, which most already areRelates to #274